[PATCH] D85594: [MachO] Add skeletal support for DriverKit platform
Greg McGary via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Thu Aug 13 22:13:40 PDT 2020
gkm added inline comments.
================
Comment at: llvm/lib/TextAPI/MachO/Platform.cpp:52
: PlatformKind::watchOS;
// TODO: add bridgeOS once in llvm::Triple
}
----------------
cishida wrote:
> DriverKit case should be included
@cishida, a case here depends on first defining `DriverKit` for `enum Triple::OSType` in `llvm/include/llvm/ADT/Triple.h`, which does not yet exist. (Same for `BridgeOS` according to your comment above). I see that properly supporting these `Triple::OSType` enums requires knowing minimum OS versions in several contexts, and knowing more about the platforms than I do.
May I commit this diff as-is, without `Triple::OSType::DriverKit`, and leave that to you?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D85594/new/
https://reviews.llvm.org/D85594
More information about the llvm-commits
mailing list