[PATCH] D85871: hwasan: Emit the globals note even when globals are uninstrumented.

[Peter Collingbourne via Phabricator via llvm-commits]

pcc added inline comments.


================
Comment at: llvm/lib/Transforms/Instrumentation/HWAddressSanitizer.cpp:369
 
+void HWAddressSanitizer::createHwasanCtorComdat() {
+  std::tie(HwasanCtorFunction, std::ignore) =
----------------
eugenis wrote:
> It's hard to review like this, but I presume this code was moved from instrumentGlobals verbatim?
Yes, aside from a new paragraph added to the long comment below. Phabricator subtly indicates that the code was moved with the yellow highlight along the left hand side of the code.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D85871/new/

https://reviews.llvm.org/D85871