[PATCH] D85871: hwasan: Emit the globals note even when globals are uninstrumented.
Evgenii Stepanov via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Thu Aug 13 13:49:25 PDT 2020
eugenis accepted this revision.
eugenis added a comment.
This revision is now accepted and ready to land.
LGTM
================
Comment at: llvm/lib/Transforms/Instrumentation/HWAddressSanitizer.cpp:369
+void HWAddressSanitizer::createHwasanCtorComdat() {
+ std::tie(HwasanCtorFunction, std::ignore) =
----------------
It's hard to review like this, but I presume this code was moved from instrumentGlobals verbatim?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D85871/new/
https://reviews.llvm.org/D85871
More information about the llvm-commits
mailing list