[PATCH] D85820: Use find_library for ncurses

Jonas Devlieghere via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Aug 13 09:01:02 PDT 2020


JDevlieghere added inline comments.


================
Comment at: llvm/cmake/config-ix.cmake:157
+      endif()
+      if(LLVM_ENABLE_TERMINFO STREQUAL FORCE_ON AND NOT HAVE_TERMINFO)
+        message(FATAL_ERROR "Failed to configure terminfo")
----------------
If `LLVM_ENABLE_TERMINFO` is set you should pass `REQUIRED` to `find_library` and have CMake print the error rather than dealing with the error handling ourself. 


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D85820/new/

https://reviews.llvm.org/D85820



More information about the llvm-commits mailing list