[PATCH] D85820: Use find_library for ncurses

[Harmen Stoppels via Phabricator via llvm-commits]

haampie added inline comments.


================
Comment at: lldb/source/Core/CMakeLists.txt:14-15
   list(APPEND LLDB_CURSES_LIBS ${CURSES_LIBRARIES} ${PANEL_LIBRARIES})
-  if(LLVM_ENABLE_TERMINFO AND HAVE_TERMINFO)
-    list(APPEND LLDB_CURSES_LIBS ${TERMINFO_LIBS})
+  if(LLVM_ENABLE_TERMINFO)
+    list(APPEND LLDB_CURSES_LIBS ${TERMINFO_LIB})
   endif()
----------------
I wonder what the logic is / should be here. `lldbCore` links against `Support` already, which includes terminfo when `LLVM_ENABLE_TERMINFO` was set. Should I just remove `if(LLVM_ENABLE_TERMINFO)` here?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D85820/new/

https://reviews.llvm.org/D85820