[PATCH] D85653: [GlobalISel][AMDGPU] Lower G_SMULH/G_UMULH

[Matt Arsenault via Phabricator via llvm-commits]

arsenm added inline comments.


================
Comment at: llvm/lib/Target/AMDGPU/AMDGPULegalizerInfo.cpp:542
+      .scalarize(0)
+      .lower();
 
----------------
The expansion can fully use packed instructions with VOP3P instructions. This should try to clamp the number of elements for 16-bit cases if available before scalarizing


================
Comment at: llvm/test/CodeGen/AMDGPU/GlobalISel/legalize-smulh.mir:41
 ...
+
+---
----------------
Should add <2 x s16>, <3 x 16> and <4 x s16> cases


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D85653/new/

https://reviews.llvm.org/D85653