[PATCH] D85653: [GlobalISel][AMDGPU] Lower G_SMULH/G_UMULH

[Jay Foad via Phabricator via llvm-commits]

foad accepted this revision.
foad added a comment.
This revision is now accepted and ready to land.

Looks OK to me modulo one inline comment, as long as Matt has no further objections.



================
Comment at: llvm/lib/CodeGen/GlobalISel/LegalizerHelper.cpp:6015-6017
+  auto NumElements = IsVector ? OrigTy.getNumElements() : 1;
+  LLT WideElementTy = LLT::scalar(SizeInBits * 2);
+  LLT WideTy = LLT::scalarOrVector(NumElements, WideElementTy);
----------------
Actually it would be neater to use `LLT::changeElementSize`.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D85653/new/

https://reviews.llvm.org/D85653