[PATCH] D85820: Use find_library for ncurses

Petr Hosek via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Aug 12 12:59:02 PDT 2020


phosek added a comment.

CMake already has FindCurses module <https://gitlab.kitware.com/cmake/cmake/-/blob/master/Modules/FindCurses.cmake> so we could consider using `find_package(Curses)`, unfortunately it doesn't define the imported target. I'd also prefer replacing `HAVE_TERMINFO` with `LLVM_ENABLE_TERMINFO` everywhere for consistency with zlib or libxml2 (see D84563 <https://reviews.llvm.org/D84563>).


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D85820/new/

https://reviews.llvm.org/D85820



More information about the llvm-commits mailing list