[PATCH] D85820: Use find_library for ncurses

[Harmen Stoppels via Phabricator via llvm-commits]

haampie added inline comments.


================
Comment at: llvm/cmake/config-ix.cmake:151-155
       set(HAVE_TERMINFO 0)
-      foreach(library terminfo tinfo curses ncurses ncursesw)
-        string(TOUPPER ${library} library_suffix)
-        check_library_exists(${library} setupterm "" HAVE_TERMINFO_${library_suffix})
-        if(HAVE_TERMINFO_${library_suffix})
-          set(HAVE_TERMINFO 1)
-          set(TERMINFO_LIBS "${library}")
-          break()
-        endif()
-      endforeach()
+      find_library(FIND_TERMINFO NAMES terminfo tinfo curses ncurses ncursesw)
+      if(FIND_TERMINFO)
+        set(HAVE_TERMINFO 1)
+        set(TERMINFO_LIBS "${FIND_TERMINFO}")
----------------
JDevlieghere wrote:
> You could simplify this a little by using `TERMINFO_LIBS` directly.
Thanks, I made it even simpler


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D85820/new/

https://reviews.llvm.org/D85820