[PATCH] D83560: [DebugInfo] Emit DW_OP_implicit_value for Floating point constants

Sourabh Singh Tomar via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Aug 12 11:01:46 PDT 2020


SouraVX added a comment.

Thank @amyk for confirming this. @aprantl and @MaskRay could you guys please share your thoughts on this.

> Temporarily removed long double support since IMHO this might require a deeper surgery. Patch reflects the overall skeleton required for suporting DW_OP_implicit_value.

I made this remark, since existing approach leads to manual padding bytes calculation. Exploring a better way to accomplish this. 
Some of these big-constants are handled in a more cleaner way in `AsmPrinter.cpp `  ` static void emitGlobalConstantFP`, but I doubt this sort of thing can be re-used. Since expression emission requires it's own streamer(`ByteStreamer`)and intricacies.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D83560/new/

https://reviews.llvm.org/D83560



More information about the llvm-commits mailing list