[PATCH] D83560: [DebugInfo] Emit DW_OP_implicit_value for Floating point constants

Amy Kwan via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Aug 11 08:49:53 PDT 2020


amyk added a comment.



In D83560#2206363 <https://reviews.llvm.org/D83560#2206363>, @SouraVX wrote:

> Thanks @MaskRay for pointers. Tried similar approach(slightly different, since expression has to be emitted by a separate streamer owned by `DebugLocDwarfExpression`) to take care of Endianess.
>
> - Temporarily removed `long double` support since IMHO this might require a deeper surgery. Patch reflects the overall skeleton required for suporting `DW_OP_implicit_value`.
> - @amyk, is it possible for you to try this patch on PPC targets ? So that we won't end up having surprises.

I have tried this patch on little endian and big endian PowerPC, everything looks OK and I do not see any failures with this patch.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D83560/new/

https://reviews.llvm.org/D83560



More information about the llvm-commits mailing list