[PATCH] D85628: [HotColdSplitting] Add command line options for supplying cold function names via user input.

Aditya Kumar via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Aug 12 05:57:40 PDT 2020


hiraditya added a comment.

In D85628#2212047 <https://reviews.llvm.org/D85628#2212047>, @vsk wrote:

> Any reason not to mark up the relevant functions with `__attribute__((cold))` directly?

In many instances it may not be not possible to annotate the functions e.g., standard library functions. A recent example we found was lock_guard_acquire which could be cold in many instances.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D85628/new/

https://reviews.llvm.org/D85628



More information about the llvm-commits mailing list