[PATCH] D85628: [HotColdSplitting] Add command line options for supplying cold function names via user input.

[Vedant Kumar via Phabricator via llvm-commits]

vsk added a comment.

Any reason not to mark up the relevant functions with `__attribute__((cold))` directly?



================
Comment at: llvm/lib/Transforms/IPO/HotColdSplitting.cpp:687
+  // Read in user-defined cold function names, if any.
+  if (ColdFunctionsList != "") {
+    std::stringstream CFStream(ColdFunctionsList);
----------------
Might be better to use SpecialCaseList.h rather than hand-rolling something new.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D85628/new/

https://reviews.llvm.org/D85628