[PATCH] D85579: [ELF] --gdb-index: skip SHF_GROUP .debug_info

[Fangrui Song via Phabricator via llvm-commits]

MaskRay added inline comments.


================
Comment at: lld/test/ELF/gdb-index-dwarf5-type-unit.s:51
+
+.macro TYPE_UNIT id signature
+.section  .debug_info,"G", at progbits,\signature
----------------
dblaikie wrote:
> MaskRay wrote:
> > @dblaikie Does this test achieve a good minimality/robustness/usefulness in your opinion?
> I think so? 
> 
> If I'm reading it correctly it's a type unit in a comdat, a compile unit, another compile unit in a distinct fragment of debug_info, and then another type unit in a comdat?
> 
> The existence of two compilation units in separate sections with the same name isn't a use case I know of any producer producing today - but if it helps test out the generality of this functionality, it sounds OK to me.
Thanks for confirmation. 

> The existence of two compilation units in separate sections with the same name isn't a use case I know of any producer producing today - but if it helps test out the generality of this functionality, it sounds OK to me.

This is super rare. `ld -r --unique` can create the case. I just want to make the behavior clearer/concise without adding another test.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D85579/new/

https://reviews.llvm.org/D85579