[PATCH] D85579: [ELF] --gdb-index: skip SHF_GROUP .debug_info
David Blaikie via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Tue Aug 11 14:16:06 PDT 2020
dblaikie added inline comments.
================
Comment at: lld/test/ELF/gdb-index-dwarf5-type-unit.s:51
+
+.macro TYPE_UNIT id signature
+.section .debug_info,"G", at progbits,\signature
----------------
MaskRay wrote:
> @dblaikie Does this test achieve a good minimality/robustness/usefulness in your opinion?
I think so?
If I'm reading it correctly it's a type unit in a comdat, a compile unit, another compile unit in a distinct fragment of debug_info, and then another type unit in a comdat?
The existence of two compilation units in separate sections with the same name isn't a use case I know of any producer producing today - but if it helps test out the generality of this functionality, it sounds OK to me.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D85579/new/
https://reviews.llvm.org/D85579
More information about the llvm-commits
mailing list