[PATCH] D85655: [llvm-install-name-tool] Add more documentation

Sameer Arora via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Aug 11 07:13:15 PDT 2020


sameerarora101 marked 3 inline comments as done.
sameerarora101 added inline comments.


================
Comment at: llvm/docs/CommandGuide/llvm-install-name-tool.rst:25-26
 
+    - Can combine :option:`-add_rpath`, :option:`-delete_rpath` and :option:`-rpath`
+      in an invocation only if they do not share the same `<rpath>` value.
+
----------------
jhenderson wrote:
> smeenai wrote:
> > Grammar nit: I'd prefer "-add_rpath, -delete_rpath, and -rpath can be combined in an invocation only if..."
> I'm not sure this should be a bullet point. It seems like it should be a new sentence at the end of the previous paragraph.
Added as a sentence. How does that look?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D85655/new/

https://reviews.llvm.org/D85655



More information about the llvm-commits mailing list