[PATCH] D85655: [llvm-install-name-tool] Add more documentation

[James Henderson via Phabricator via llvm-commits]

jhenderson accepted this revision.
jhenderson added a comment.

Mostly looks good.



================
Comment at: llvm/docs/CommandGuide/llvm-install-name-tool.rst:25-26
 
+    - Can combine :option:`-add_rpath`, :option:`-delete_rpath` and :option:`-rpath`
+      in an invocation only if they do not share the same `<rpath>` value.
+
----------------
smeenai wrote:
> Grammar nit: I'd prefer "-add_rpath, -delete_rpath, and -rpath can be combined in an invocation only if..."
I'm not sure this should be a bullet point. It seems like it should be a new sentence at the end of the previous paragraph.


================
Comment at: llvm/docs/CommandGuide/llvm-install-name-tool.rst:59-60
+
+
+
 EXIT STATUS
----------------
Let's get rid of the excessive new lines!


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D85655/new/

https://reviews.llvm.org/D85655