[PATCH] D85670: [Instruction] Add updateLocationAfterHoist helper

[Vedant Kumar via Phabricator via llvm-commits]

vsk created this revision.
vsk added reviewers: dblaikie, aprantl.
Herald added subscribers: asbirlea, hiraditya.
Herald added a project: LLVM.
vsk requested review of this revision.

Introduce a helper on Instruction which can be used to update the debug
location after hoisting.

Use this in GVN and LICM, where we were mistakenly introducing new line
0 locations after hoisting (the docs recommend dropping the location in
this case).

For more context, see the discussion in https://reviews.llvm.org/D60913.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D85670

Files:
  llvm/include/llvm/IR/Instruction.h
  llvm/lib/IR/DebugInfo.cpp
  llvm/lib/Transforms/Scalar/GVN.cpp
  llvm/lib/Transforms/Scalar/LICM.cpp
  llvm/test/DebugInfo/Generic/licm-hoist-debug-loc.ll
  llvm/test/Transforms/GVN/PRE/phi-translate.ll
  llvm/test/Transforms/LICM/hoisting-preheader-debugloc.ll
  llvm/unittests/IR/InstructionsTest.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D85670.284440.patch
Type: text/x-patch
Size: 7820 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20200810/8b258d22/attachment.bin>