[PATCH] D85669: Fix "accessed timestamp" test failing on Windows
Alexandre Ganea via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Mon Aug 10 10:44:50 PDT 2020
aganea created this revision.
aganea added reviewers: amccarth, MaskRay, rupprecht.
Herald added subscribers: llvm-commits, emaste.
Herald added a reviewer: espindola.
Herald added a reviewer: alexshap.
Herald added a reviewer: jhenderson.
Herald added a project: LLVM.
aganea requested review of this revision.
The tests in `llvm/test/tools/llvm-objcopy/ELF/strip-preserve-atime.test` fail on my machine, because the last accessed time is disabled in the OS by default since Windows XP. One needs to explicitly enable it for the feature to work. Otherwise the last access time is the last write time. Please see: https://superuser.com/questions/251263/the-last-access-date-is-not-changed-even-after-reading-the-file-on-windows-7
Repository:
rG LLVM Github Monorepo
https://reviews.llvm.org/D85669
Files:
llvm/test/tools/llvm-objcopy/ELF/strip-preserve-atime.test
Index: llvm/test/tools/llvm-objcopy/ELF/strip-preserve-atime.test
===================================================================
--- llvm/test/tools/llvm-objcopy/ELF/strip-preserve-atime.test
+++ llvm/test/tools/llvm-objcopy/ELF/strip-preserve-atime.test
@@ -1,6 +1,6 @@
# Note: ls -lu prints the accessed timestamp
# NetBSD: noatime mounts currently inhibit 'touch -a' updates
-# UNSUPPORTED: system-netbsd
+# UNSUPPORTED: system-netbsd, system-windows
# Preserve dates when stripping to an output file.
# RUN: yaml2obj %s -o %t.1.o
-------------- next part --------------
A non-text attachment was scrubbed...
Name: D85669.284438.patch
Type: text/x-patch
Size: 545 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20200810/88b32732/attachment.bin>
More information about the llvm-commits
mailing list