[PATCH] D85577: [NFC][MLInliner] Set up the logger outside the development mode advisor

Fangrui Song via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sat Aug 8 21:26:22 PDT 2020


MaskRay added inline comments.


================
Comment at: llvm/lib/Analysis/DevelopmentModeInlineAdvisor.cpp:371
+void TrainingLogger::print() {
+  std::error_code ErrorCode;
+  raw_fd_ostream OutFile(LogFileName, ErrorCode);
----------------
A common variable name of type error_code is `EC`. You may consider it


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D85577/new/

https://reviews.llvm.org/D85577



More information about the llvm-commits mailing list