[PATCH] D85577: [NFC][MLInliner] Set up the logger outside the development mode advisor
Yundi Qian via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Sat Aug 8 20:16:18 PDT 2020
yundiqian accepted this revision.
yundiqian added inline comments.
This revision is now accepted and ready to land.
================
Comment at: llvm/lib/Analysis/DevelopmentModeInlineAdvisor.cpp:400-401
std::unique_ptr<MLModelRunner> ModelRunner,
- std::function<bool(CallBase &)> GetDefaultAdvice, bool IsDoingInference)
+ std::function<bool(CallBase &)> GetDefaultAdvice, bool IsDoingInference,
+ std::unique_ptr<TrainingLogger> Logger)
: MLInlineAdvisor(M, MAM, std::move(ModelRunner)),
----------------
swap IsDoingInference and Logger so that the sequence matches?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D85577/new/
https://reviews.llvm.org/D85577
More information about the llvm-commits
mailing list