[PATCH] D85581: [WebAssembly] Fix FastISel address calculation bug

[Thomas Lively via Phabricator via llvm-commits]

tlively added a comment.

In D85581#2204725 <https://reviews.llvm.org/D85581#2204725>, @sbc100 wrote:

> "The issue was that an Address set to
> be relative to the FrameIndex with offset zero was incorrectly
> considered to have an unset base. "
>
> From the patch I can't see how offset (which I assume means the `Offset` member) comes into play at all.     It looks like the fix applies to when either the `FI` or the `Ref` itself is zero.    Or should I read `FrameIndex with offset zero` to mean `FrameIndex of zero` ?

Oh you're right. It's not the Offset but the FrameIndex itself. I'll fix the commit message and comment.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D85581/new/

https://reviews.llvm.org/D85581