[PATCH] D85581: [WebAssembly] Fix FastISel address calculation bug

Sam Clegg via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sat Aug 8 08:29:46 PDT 2020


sbc100 added a comment.

"The issue was that an Address set to
be relative to the FrameIndex with offset zero was incorrectly
considered to have an unset base. "

>From the patch I can't see how offset (which I assume means the `Offset` member) comes into play at all.     It looks like the fix applies to when either the `FI` or the `Ref` itself is zero.    Or should I read `FrameIndex with offset zero` to mean `FrameIndex of zero` ?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D85581/new/

https://reviews.llvm.org/D85581



More information about the llvm-commits mailing list