[PATCH] D85153: [lld-macho] Add .tbd support for frameworks

[Shoaib Meenai via Phabricator via llvm-commits]

smeenai added inline comments.


================
Comment at: lld/MachO/Driver.cpp:123
+        // only append suffix if realpath() succeeds
+        Twine suffixed = location + suffix;
+        if (fs::exists(suffixed))
----------------
int3 wrote:
> smeenai wrote:
> > Does ld64 also not check for tbds if there's a suffix?
> It just checks for the non-suffixed name when considering tbds. I debated on whether I should add a test for this behavior, since it's not clear to me that ld64 intended for it to work this way. The test might just be codifying an irrelevant implementation detail...
Sure, makes sense.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D85153/new/

https://reviews.llvm.org/D85153