[PATCH] D85153: [lld-macho] Add .tbd support for frameworks
Jez Ng via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Wed Aug 5 23:15:19 PDT 2020
int3 added inline comments.
================
Comment at: lld/MachO/Driver.cpp:123
+ // only append suffix if realpath() succeeds
+ Twine suffixed = location + suffix;
+ if (fs::exists(suffixed))
----------------
smeenai wrote:
> Does ld64 also not check for tbds if there's a suffix?
It just checks for the non-suffixed name when considering tbds. I debated on whether I should add a test for this behavior, since it's not clear to me that ld64 intended for it to work this way. The test might just be codifying an irrelevant implementation detail...
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D85153/new/
https://reviews.llvm.org/D85153
More information about the llvm-commits
mailing list