[PATCH] D85478: [NewPM] Add callback for skipped passes

[Yuanfang Chen via Phabricator via llvm-commits]

ychen added a comment.

LGTM with one nit.



================
Comment at: llvm/unittests/IR/PassBuilderCallbacksTest.cpp:737
+  EXPECT_CALL(CallbacksHandle,
+              runBeforeSkippedPass(HasNameRegex("MockPassHandle"), _))
+      .Times(1);
----------------
underscore?


================
Comment at: llvm/unittests/IR/PassBuilderCallbacksTest.cpp:549
   CallbacksHandle.ignoreNonMockPassInstrumentation("<string>");
+  CallbacksHandle.ignoreNonMockPassInstrumentation("foo");
 
----------------
aeubanks wrote:
> ychen wrote:
> > Maybe we don't need this? This test fixture is for module passes. foo is a function name. Since the Module is always in memory without a filename, the Module::getName(() gives "<string>".
> This test runs a module pass, a function pass, and a loop pass, which is why this is necessary.
I see. Thanks.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D85478/new/

https://reviews.llvm.org/D85478