[PATCH] D85478: [NewPM] Add callback for skipped passes

[Arthur Eubanks via Phabricator via llvm-commits]

aeubanks added inline comments.


================
Comment at: llvm/unittests/IR/PassBuilderCallbacksTest.cpp:549
   CallbacksHandle.ignoreNonMockPassInstrumentation("<string>");
+  CallbacksHandle.ignoreNonMockPassInstrumentation("foo");
 
----------------
ychen wrote:
> Maybe we don't need this? This test fixture is for module passes. foo is a function name. Since the Module is always in memory without a filename, the Module::getName(() gives "<string>".
This test runs a module pass, a function pass, and a loop pass, which is why this is necessary.


================
Comment at: llvm/unittests/IR/PassBuilderCallbacksTest.cpp:734
   // as well.
+  EXPECT_CALL(CallbacksHandle,
+              runBeforeNonSkippedPass(HasNameRegex("MockPassHandle"), _))
----------------
ychen wrote:
> Thanks for catching these `runBeforeNonSkippedPass` that I missed previously. Maybe move these to a separate patch?
I'm lazy and think it's too much work for a new patch :)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D85478/new/

https://reviews.llvm.org/D85478