[PATCH] D85255: [lld-macho] Generate ObjC symbols from .tbd files

Thu Aug 6 10:09:12 PDT 2020

compnerd added inline comments.

================
Comment at: lld/MachO/InputFiles.cpp:421
+      break;
+    }
+  }
----------------
smeenai wrote:
> int3 wrote:
> > compnerd wrote:
> > > Same as last time - would be nice to actually compose with the user label prefix.
> > > 
> > > Remember that `x86_64-apple-coff` is a real target - and the user label prefix is empty there.  This breaks because you are assuming that the user label prefix is `_`.
> > > Remember that x86_64-apple-coff is a real target
> > 
> > oh what... is this actually used?
> I believe it's used for UEFI. Presumably that's something for LLD for COFF to worry about and not LLD for Mach-O though, right? Also, I'd be surprised if Objective-C is being used for UEFI :)
Sorry, that was a partial thought.  What I was getting at is that the user label prefix is important and in that case, you have MachO conversions that occur.  We should be more careful about the user label prefix rather than assume that it is guaranteed to be `_`.  That is a convention that is target dependent and not MachO dependent.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D85255/new/

https://reviews.llvm.org/D85255