[PATCH] D85255: [lld-macho] Generate ObjC symbols from .tbd files

[Shoaib Meenai via Phabricator via llvm-commits]

smeenai added inline comments.


================
Comment at: lld/MachO/InputFiles.cpp:410
+    case SymbolKind::ObjectiveCClass:
+      // XXX ld64 only creates these symbols when -ObjC is passed in. We may
+      // want to emulate that.
----------------
Huh, interesting. I thought `-ObjC` only influenced the behavior for static libraries.


================
Comment at: lld/MachO/InputFiles.cpp:421
+      break;
+    }
+  }
----------------
int3 wrote:
> compnerd wrote:
> > Same as last time - would be nice to actually compose with the user label prefix.
> > 
> > Remember that `x86_64-apple-coff` is a real target - and the user label prefix is empty there.  This breaks because you are assuming that the user label prefix is `_`.
> > Remember that x86_64-apple-coff is a real target
> 
> oh what... is this actually used?
I believe it's used for UEFI. Presumably that's something for LLD for COFF to worry about and not LLD for Mach-O though, right? Also, I'd be surprised if Objective-C is being used for UEFI :)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D85255/new/

https://reviews.llvm.org/D85255