[PATCH] D85178: [Attributor] Check violation of returned position nonnull and noundef attribute in AAUndefinedBehavior
Shinji Okumura via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Thu Aug 6 09:34:26 PDT 2020
okura marked an inline comment as done.
okura added inline comments.
================
Comment at: llvm/lib/Transforms/IPO/AttributorAttributes.cpp:2057
+ // (1) Returned value is known to be dead (because it can be reduced
+ // to undef).
+ // (2) The value is known to be undef.
----------------
jdoerfert wrote:
> Reading this makes me question if it should ever happen. I hope AAReturnedValues will not look at dead returns so they should not be part of the RetInsts set and if that set is empty this should never be called.
I overlooked the fact that a dead return instruction is ignored in `checkForAllReturnedValuesAndReturnInsts`. I'll fix this comment.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D85178/new/
https://reviews.llvm.org/D85178
More information about the llvm-commits
mailing list