[PATCH] D85234: [AMDGPU] Scavenge temp reg for AGPR spill

Matt Arsenault via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Aug 5 10:54:52 PDT 2020


arsenm added inline comments.


================
Comment at: llvm/lib/Target/AMDGPU/SIRegisterInfo.cpp:824
+        if (TmpReg == AMDGPU::NoRegister) {
+          // FIXME: change to scavengeRegisterBackwards()
+          TmpReg = RS->scavengeRegister(&AMDGPU::VGPR_32RegClass, MI, 0);
----------------
Should assert on RS in case this ever gets called from PEI and we didn't enable the scavenger


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D85234/new/

https://reviews.llvm.org/D85234



More information about the llvm-commits mailing list