[PATCH] D85414: [test][DebugInfo] Adapt two tests for Sun assembler syntax on Sparc

[James Henderson via Phabricator via llvm-commits]

jhenderson added inline comments.


================
Comment at: llvm/test/DebugInfo/Generic/2010-06-29-InlinedFnLocalVar.ll:4
 
-; CHECK: debug_info,
+; CHECK: debug_info{{,|$}}
 ; CHECK:	DW_TAG_structure_type
----------------
Unless you think it's important to verify the name exactly ends with "debug_info" (note that this line doesn't check that the name starts with "debug_info", so could pass with e.g. ".some_random_text_debug_info"), you can just get rid of the ',' instead.

Honestly, I'm not really sure what the point of checking the line is at all... It doesn't prove that the next two lines are in the .debug_info section, because a) the first check doesn't actually check the full section directive to show that it's referring to a section directive, and b) there could be anything, including other section directives between the check and the lines below... Same goes with the other test. I'm not sure if it's worth fixing things further thought...


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D85414/new/

https://reviews.llvm.org/D85414