[PATCH] D85414: [test][DebugInfo] Adapt two tests for Sun assembler syntax on Sparc

[Rainer Orth via Phabricator via llvm-commits]

ro created this revision.
ro added reviewers: echristo, jhenderson, dblaikie, MaskRay.
Herald added subscribers: fedor.sergeev, jyknight.
Herald added a project: LLVM.
ro requested review of this revision.

Two DebugInfo tests currently `FAIL` on Sparc:

  LLVM :: DebugInfo/Generic/2010-06-29-InlinedFnLocalVar.ll
  LLVM :: DebugInfo/Generic/array.ll

both in a similar way.  E.g.

  : 'RUN: at line 1';   /var/llvm/local-sparcv9-A/bin/llc -O2 /vol/llvm/src/llvm-project/local/llvm/test/DebugInfo/Generic/2010-06-29-InlinedFnLocalVar.ll -o - | /var/llvm/local-sparcv9-A/bin/FileCheck /vol/llvm/src/llvm-project/local/llvm/test/DebugInfo/Generic/2010-06-29-InlinedFnLocalVar.ll
  
  /vol/llvm/src/llvm-project/local/llvm/test/DebugInfo/Generic/2010-06-29-InlinedFnLocalVar.ll:4:10: error: CHECK: expected string not found in input
  ; CHECK: debug_info,
           ^

On `amd64-pc-solaris2.11`, the corresponding line is

  .section        .debug_info,"", at progbits

while on `sparcv9-sun-solaris2.11` we have only

  .section        .debug_info

This happens because Sparc currently emits `.section` directives using the style of the Solaris/SPARC assembler (controlled by `SunStyleELFSectionSwitchSyntax`).

This patch takes the easy way out and allows both forms.

Tested on `sparcv9-sun-solaris2.11` and `amd64-pc-solaris2.11`.

Alternatively, one could think about changing the default to the common GNU `as`
syntax instead to avoid issues like this one.  I've a separate patch that goes that route, to be submitted shortly.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D85414

Files:
  llvm/test/DebugInfo/Generic/2010-06-29-InlinedFnLocalVar.ll
  llvm/test/DebugInfo/Generic/array.ll


Index: llvm/test/DebugInfo/Generic/array.ll
===================================================================
--- llvm/test/DebugInfo/Generic/array.ll
+++ llvm/test/DebugInfo/Generic/array.ll
@@ -25,7 +25,7 @@
 !7 = distinct !DILexicalBlock(line: 3, column: 12, file: !14, scope: !0)
 !8 = !DICompositeType(tag: DW_TAG_array_type, align: 32, file: !14, scope: !2, baseType: !5, elements: !9)
 !9 = !{!10}
-;CHECK: debug_info,
+;CHECK: debug_info{{,|$}}
 ;CHECK: DW_TAG_subrange_type
 ;CHECK-NEXT: DW_AT_type
 ;CHECK-NOT: DW_AT_lower_bound
Index: llvm/test/DebugInfo/Generic/2010-06-29-InlinedFnLocalVar.ll
===================================================================
--- llvm/test/DebugInfo/Generic/2010-06-29-InlinedFnLocalVar.ll
+++ llvm/test/DebugInfo/Generic/2010-06-29-InlinedFnLocalVar.ll
@@ -1,7 +1,7 @@
 ; RUN: %llc_dwarf -O2 %s -o - | FileCheck %s
 ; Check struct X for dead variable xyz from inlined function foo.
 
-; CHECK: debug_info,
+; CHECK: debug_info{{,|$}}
 ; CHECK:	DW_TAG_structure_type
 ; CHECK-NEXT:	DW_AT_name
 


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D85414.283535.patch
Type: text/x-patch
Size: 1045 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20200806/43781e95/attachment.bin>