[PATCH] D85080: [lld-macho] Support static linking of thread-locals

[Shoaib Meenai via Phabricator via llvm-commits]

smeenai accepted this revision.
smeenai added a comment.

LGTM



================
Comment at: lld/MachO/InputSection.cpp:39
+    if (auto *s = r.target.dyn_cast<Symbol *>()) {
+      va = target->getSymbolVA(buf + r.offset, *s, r.type);
+
----------------
I'm assuming this should be `resolveSymbolVA`?


================
Comment at: lld/MachO/InputSection.cpp:41
+
+      if (isThreadLocalVariables(flags)) {
+        // References from thread-local variable sections are treated as
----------------
Is this not being put in `resolveSymbolVA` because it's target-independent?

Also, this is pretty strange ... I wonder why it's set up like this.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D85080/new/

https://reviews.llvm.org/D85080