[PATCH] D84822: Add target ID to AMDGPU documentation

Jon Chesterfield via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Aug 5 07:01:16 PDT 2020


JonChesterfield added inline comments.


================
Comment at: llvm/docs/AMDGPUUsage.rst:386
+
+  *On*
+    Specified by ``+``, indicating the target feature is enabled. A code
----------------
The on/off division seems likely to cause us problems later. How about 0/1 instead, so that we can later add 2, 3 etc when a feature is added that has more than two states?

Or strings.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D84822/new/

https://reviews.llvm.org/D84822



More information about the llvm-commits mailing list