[PATCH] D84822: Add target ID to AMDGPU documentation

[Yaxun Liu via Phabricator via llvm-commits]

yaxunl marked an inline comment as done.
yaxunl added inline comments.


================
Comment at: llvm/docs/AMDGPUUsage.rst:1290
+Bundled Code Objects
+====================
+
----------------
jdoerfert wrote:
> Isn't this a generic thing that is (to be) used by all targets, not just AMDGPU? Should we instead document it elsewhere and link it here? I guess the same could be said for the target id stuff but there people don't really use it elsewhere yet.
There are two usage of `clang-offload-bundler`:


  #  As a generic bundler for clang intermediate files, including preprocessor outputs, LLVM bitcode, object files. The consumer is clang.

  # As a code object bundler (or so called fat binary) which bundles code objects for different GPU's so that it can be embedded in an executable or shared library. The consumer is HIP runtime.

Here we only describe the second usage of `clang-offload-bundler`, which is only used by AMDGPU target. As you can see it refers to `code objects` and `target ID`. Therefore it is better kept in AMDGPU documentation.




CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D84822/new/

https://reviews.llvm.org/D84822