[PATCH] D85100: [ELF] Allow sections after a non-allocable section to be covered by PT_LOAD

[Fangrui Song via Phabricator via llvm-commits]

MaskRay added inline comments.


================
Comment at: lld/ELF/Writer.cpp:1237
               std::vector<BaseCommand *>::iterator e) {
+  // To make the addresses of orphan sections not affected by non-allocable
+  // sections in the middle, place orphan non-allocable sections in the end.
----------------
jhenderson wrote:
> I think the term is "non-allocatable".
gABI uses "non-allocable" in one place (SHF_COMPRESSED, contributed by Solaris folks)

> SHF_COMPRESSED
>
> This flag identifies a section containing compressed data. SHF_COMPRESSED applies only to non-allocable sections, and cannot be used in conjunction with SHF_ALLOC. In addition, SHF_COMPRESSED cannot be applied to sections of type SHT_NOBITS.

I don't find a use of "non-allocatable".


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D85100/new/

https://reviews.llvm.org/D85100