[PATCH] D85100: [ELF] Allow sections after a non-allocable section to be covered by PT_LOAD

[Fangrui Song via Phabricator via llvm-commits]

MaskRay updated this revision to Diff 282724.
MaskRay marked an inline comment as done.
MaskRay added a comment.

> Current LLD behaviour is to ignore linker script positioning of non-allocatable sections and put them after all allocatable sections, and this changes to placing them in the output in their requested position

For PT_LOAD creation, current LLD behaviors ignores every section after a non-allocable section.
This changes them to be allocated into some PT_LOAD. The non-allocable placement is arbitrary: their observed behaviors are not guaranteed property.

> Do we have/need a test case for non-alloc between two sections which are in different segments, e.g:

Added a test that .data .bss .comment .other can be in one PT_LOAD.
This is not something we strive to satisfy, just a result of current implementation choice.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D85100/new/

https://reviews.llvm.org/D85100

Files:
  lld/ELF/LinkerScript.cpp
  lld/ELF/Writer.cpp
  lld/test/ELF/linkerscript/compress-debug-sections-custom.s
  lld/test/ELF/linkerscript/sections.s
  lld/test/ELF/linkerscript/symbols-non-alloc.test

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D85100.282724.patch
Type: text/x-patch
Size: 8872 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20200803/e07bf092/attachment.bin>