[PATCH] D85041: [llvm-libtool-darwin] Add constant CPU_TYPE_ARM64_V8

[Sameer Arora via Phabricator via llvm-commits]

sameerarora101 marked 2 inline comments as done.
sameerarora101 added inline comments.


================
Comment at: llvm/tools/llvm-objdump/MachODump.cpp:2108
     switch (cpusubtype & ~MachO::CPU_SUBTYPE_MASK) {
     case MachO::CPU_SUBTYPE_ARM64_ALL:
       outs() << "    cputype CPU_TYPE_ARM64\n";
----------------
jhenderson wrote:
> Are there tests for these other cases too? If not, perhaps we should make the new test more generic, and test them all in one test?
Under `llvm-objdump`, for CPU-TYPE  `CPU_TYPE_ARM64`, 
- there is one test case for subtype `CPU_SUBTYPE_ARM64E` (macho-arm64e.test)
- one test case (which I added above) for `CPU_SUBTYPE_ARM64_V8` (macho-arm64-v8.test)
- all remaining tests are for subtype `CPU_SUBTYPE_ARM64_ALL`


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D85041/new/

https://reviews.llvm.org/D85041