[PATCH] D85041: [llvm-libtool-darwin] Add constant CPU_TYPE_ARM64_V8

Mon Aug 3 01:00:11 PDT 2020

jhenderson added a comment.

In D85041#2188548 <https://reviews.llvm.org/D85041#2188548>, @alexshap wrote:

> I'd probably add a simple test for llvm-readobj as well.

+1. Whilst you're at it. You might as well test the other types too in that enum (assuming they aren't already tested). You can use `yaml2obj`'s `-D` to reuse the YAML for each input file.

================
Comment at: llvm/test/tools/llvm-objdump/MachO/AArch64/Inputs/arm64_v8.macho.yaml:1
+--- !mach-o
+FileHeader:
----------------
As this input is only used in one place, you can put it inline with the test that uses it. You'll need to use '#' for the RUN/CHECKs in the test then.

================
Comment at: llvm/tools/llvm-objdump/MachODump.cpp:2108
     switch (cpusubtype & ~MachO::CPU_SUBTYPE_MASK) {
     case MachO::CPU_SUBTYPE_ARM64_ALL:
       outs() << "    cputype CPU_TYPE_ARM64\n";
----------------
Are there tests for these other cases too? If not, perhaps we should make the new test more generic, and test them all in one test?

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D85041/new/

https://reviews.llvm.org/D85041