[PATCH] D85094: [obj2yaml] Add support for dumping the .debug_aranges section.

Xing GUO via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sun Aug 2 21:20:10 PDT 2020


Higuoxing added inline comments.


================
Comment at: llvm/tools/obj2yaml/elf2yaml.cpp:411
+      if (Err)
+        consumeError(std::move(Err));
+      else
----------------
I want to hear suggestions on handling the parsing error here. I think it would be good if we can 
emit a warning or add a comment about the details of parsing failure in the generated YAML description. e.g.,

1) Emit a warning
```
$ obj2yaml a.out
...
obj2yaml warning: obj2yaml doesn't support parsing the address range table whose segment selector size is not 0.
```

2) Add a comment field.
```
Sections:
  - Name:    '.debug_aranges'
    Type:    SHT_PROGBITS
    Content: '01234567890abcdef'
    Comment: 'obj2yaml doesn't support parsing the address range table whose segment selector size is not 0.'
```


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D85094/new/

https://reviews.llvm.org/D85094



More information about the llvm-commits mailing list