[llvm] 20fbbbc - [X86] Use const APInt& in for-range loop to avoid unnecessary copies. NFCI.

Simon Pilgrim via llvm-commits llvm-commits at lists.llvm.org
Sun Aug 2 06:33:09 PDT 2020


Author: Simon Pilgrim
Date: 2020-08-02T14:32:23+01:00
New Revision: 20fbbbc583f4d7a35c380b0b88ea96cff0237856

URL: https://github.com/llvm/llvm-project/commit/20fbbbc583f4d7a35c380b0b88ea96cff0237856
DIFF: https://github.com/llvm/llvm-project/commit/20fbbbc583f4d7a35c380b0b88ea96cff0237856.diff

LOG: [X86] Use const APInt& in for-range loop to avoid unnecessary copies. NFCI.

Fixes clang-tidy warning.

Added: 
    

Modified: 
    llvm/lib/Target/X86/X86ISelLowering.cpp

Removed: 
    


################################################################################
diff  --git a/llvm/lib/Target/X86/X86ISelLowering.cpp b/llvm/lib/Target/X86/X86ISelLowering.cpp
index 26904f8945ee..15f283b1bc42 100644
--- a/llvm/lib/Target/X86/X86ISelLowering.cpp
+++ b/llvm/lib/Target/X86/X86ISelLowering.cpp
@@ -42976,7 +42976,7 @@ static SDValue combineAnd(SDNode *N, SelectionDAG &DAG,
     if (VT == SrcVecVT.getScalarType() &&
         N->getOperand(0)->isOnlyUserOf(SrcVec.getNode()) &&
         getTargetConstantBitsFromNode(BitMask, 8, UndefElts, EltBits) &&
-        llvm::all_of(EltBits, [](APInt M) {
+        llvm::all_of(EltBits, [](const APInt &M) {
           return M.isNullValue() || M.isAllOnesValue();
         })) {
       unsigned NumElts = SrcVecVT.getVectorNumElements();


        


More information about the llvm-commits mailing list