[PATCH] D84925: [SimpleLoopUnswitch] Preserve make.implicit in non-trivial unswitch if legal

Max Kazantsev via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jul 30 21:36:02 PDT 2020


mkazantsev added inline comments.


================
Comment at: llvm/lib/Transforms/Scalar/SimpleLoopUnswitch.cpp:2080
+    ICFLoopSafetyInfo SafetyInfo;
+    SafetyInfo.computeLoopSafetyInfo(&L);
+    if (!SafetyInfo.isGuaranteedToExecute(TI, &DT, &L))
----------------
asbirlea wrote:
> I'm wondering if there is a case where we'd rather always drop the metadata than incur the cost of computing loop safety info (i.e. if a flag should exist to have this option).
I can add such flag as a follow-up. Thanks for idea!


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D84925/new/

https://reviews.llvm.org/D84925



More information about the llvm-commits mailing list