[PATCH] D84925: [SimpleLoopUnswitch] Preserve make.implicit in non-trivial unswitch if legal

[Alina Sbirlea via Phabricator via llvm-commits]

asbirlea accepted this revision.
asbirlea added a comment.
This revision is now accepted and ready to land.

lgtm



================
Comment at: llvm/lib/Transforms/Scalar/SimpleLoopUnswitch.cpp:2080
+    ICFLoopSafetyInfo SafetyInfo;
+    SafetyInfo.computeLoopSafetyInfo(&L);
+    if (!SafetyInfo.isGuaranteedToExecute(TI, &DT, &L))
----------------
I'm wondering if there is a case where we'd rather always drop the metadata than incur the cost of computing loop safety info (i.e. if a flag should exist to have this option).


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D84925/new/

https://reviews.llvm.org/D84925