[PATCH] D84570: [tsan] Fix the open and open64 interceptors to have correct declarations (variadic functions)

[Kuba (Brecka) Mracek via Phabricator via llvm-commits]

kubamracek added inline comments.


================
Comment at: compiler-rt/test/tsan/Darwin/variadic-open.cpp:1
+// RUN: %clangxx_tsan -O1 %s -o %t && %run %t %t.tmp 2>&1 | FileCheck %s
+#include <stdio.h>
----------------
MaskRay wrote:
> Is this Darwin specific or does it apply to aarch64-linux as well?
I believe this is Darwin specific. See <https://developer.apple.com/library/archive/documentation/Xcode/Conceptual/iPhoneOSABIReference/Articles/ARM64FunctionCallingConventions.html> which explains that all variadic arguments are always passed on the stack.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D84570/new/

https://reviews.llvm.org/D84570