[PATCH] D84570: [tsan] Fix the open and open64 interceptors to have correct declarations (variadic functions)
Vitaly Buka via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Tue Jul 28 00:06:38 PDT 2020
vitalybuka accepted this revision.
vitalybuka added a comment.
This revision is now accepted and ready to land.
Could you please move it one dir up with suggested changes?
Or maybe just drop "CHECK: permissions ="
================
Comment at: compiler-rt/test/tsan/Darwin/variadic-open.cpp:12
+ unlink(argv[1]);
+ int fd = open(argv[1], O_RDWR | O_CREAT, 0644);
+ assert(fd != -1);
----------------
somehow on linux even if file has 644 and argument is 644
fstat below returns 640
================
Comment at: compiler-rt/test/tsan/Darwin/variadic-open.cpp:23
+// CHECK: Hello world.
+// CHECK: permissions = 0644
+// CHECK: Done.
----------------
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D84570/new/
https://reviews.llvm.org/D84570
More information about the llvm-commits
mailing list