[PATCH] D84662: [llvm-libtool-darwin] Refactor Slice and writeUniversalBinary

[Alexander Shaposhnikov via Phabricator via llvm-commits]

alexshap added inline comments.


================
Comment at: llvm/tools/llvm-lipo/llvm-lipo.cpp:543
+
+  llvm::stable_sort(Slices);
+  if (Error E = writeUniversalBinary(Slices, OutputFileName))
----------------
smeenai wrote:
> What's the reason for not doing this sort inside writeUniversalBinary itself?
Unless I'm missing something, it seems to be more natural / a better separation of concerns.
Plus now the signature of this function has cleaned up a bit (ArrayRef)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D84662/new/

https://reviews.llvm.org/D84662