[PATCH] D84662: [llvm-libtool-darwin] Refactor Slice and writeUniversalBinary
Shoaib Meenai via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Tue Jul 28 14:02:19 PDT 2020
smeenai added inline comments.
================
Comment at: llvm/tools/llvm-lipo/llvm-lipo.cpp:543
+
+ llvm::stable_sort(Slices);
+ if (Error E = writeUniversalBinary(Slices, OutputFileName))
----------------
What's the reason for not doing this sort inside writeUniversalBinary itself?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D84662/new/
https://reviews.llvm.org/D84662
More information about the llvm-commits
mailing list