[PATCH] D84768: [flang][NFC] Extract name resolution for OpenACC & OpenMP into new file

[Tim Keith via Phabricator via llvm-commits]

tskeith added inline comments.


================
Comment at: flang/lib/Semantics/resolve-directives.cpp:309
+    const parser::DoConstruct &x) {
+  auto &loopControl{x.GetLoopControl().value()};
+  using Bounds = parser::LoopControl::Bounds;
----------------
clementval wrote:
> Add const here as suggested?
OK


================
Comment at: flang/lib/Semantics/resolve-directives.cpp:769
+
+  auto &outer{std::get<std::optional<parser::DoConstruct>>(x.t)};
+  for (const parser::DoConstruct *loop{&*outer}; loop && level > 0; --level) {
----------------
clementval wrote:
> Add const here as suggested?
OK


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D84768/new/

https://reviews.llvm.org/D84768