[PATCH] D84768: [flang][NFC] Extract name resolution for OpenACC & OpenMP into new file

[Valentin Clement via Phabricator via llvm-commits]

clementval accepted this revision.
clementval added a comment.
This revision is now accepted and ready to land.

Thanks for working on this. LGTM besides the two small clang-tidy warnings that were in the original code anyway. It is maybe good if @ichoyjx gives an inputs.



================
Comment at: flang/lib/Semantics/resolve-directives.cpp:309
+    const parser::DoConstruct &x) {
+  auto &loopControl{x.GetLoopControl().value()};
+  using Bounds = parser::LoopControl::Bounds;
----------------
Add const here as suggested?


================
Comment at: flang/lib/Semantics/resolve-directives.cpp:769
+
+  auto &outer{std::get<std::optional<parser::DoConstruct>>(x.t)};
+  for (const parser::DoConstruct *loop{&*outer}; loop && level > 0; --level) {
----------------
Add const here as suggested?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D84768/new/

https://reviews.llvm.org/D84768